Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JD40 keymap for myoung34 #9545

Merged
merged 2 commits into from
Jun 27, 2020
Merged

Add JD40 keymap for myoung34 #9545

merged 2 commits into from
Jun 27, 2020

Conversation

myoung34
Copy link
Contributor

Description

Add JD40 keymap for my layout

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 26, 2020 05:20
@myoung34 myoung34 requested review from fauxpark and removed request for a team June 26, 2020 12:05
@myoung34
Copy link
Contributor Author

@fauxpark I saw your other PR about info.json here, is that whats blocking here?
Im just trying to add a keymap, it looks like helix is missing it in this action failure

keyboards/jd40/info.json does exist though

@Erovia Erovia requested a review from a team June 26, 2020 21:07
@fauxpark
Copy link
Member

The PR lint error is because the difference between your branch and current master includes #9528, which fixes some (but not all) of the info.json errors on the Helix boards. If you rebased your branch onto current master, the difference would only include your commits, so the CI action will only look at your changes.

@myoung34
Copy link
Contributor Author

Didnt realize that was fixed upstream.
Rebased

@Erovia Erovia merged commit 751a178 into qmk:master Jun 27, 2020
@myoung34 myoung34 deleted the jd40_myoung34 branch June 29, 2020 00:15
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@myoung34 @fauxpark @jakobaa
Add JD40 keymap for myoung34 (qmk#9545)
1b2d67d 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myoung34 @fauxpark @Erovia